From f1024104a6407f46f5ccb3f1e07906a1108886b6 Mon Sep 17 00:00:00 2001
From: Benjamin Rechsteiner <benjamin.rechsteiner@abacus.ch>
Date: Wed, 23 Mar 2022 07:48:45 +0100
Subject: [PATCH] fix empty array check

---
 sslvpn-route.sh | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/sslvpn-route.sh b/sslvpn-route.sh
index 1355cf5..193c96c 100755
--- a/sslvpn-route.sh
+++ b/sslvpn-route.sh
@@ -17,6 +17,7 @@ ME=$(basename "${0}")
 SYSLOG=false
 RED='\033[0;31m'
 NC='\033[0m'
+declare -a ips
 
 function usage {
 	echo "Usage: ${ME} <IP or Hostname>" >&2
@@ -111,16 +112,17 @@ function error {
 
 function getIps {
 	if [[ ${dest} =~ ^((25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.){3}(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)$ ]]; then
-		ips=("${dest}")
+		debug 'Detect an IP adress'
+		ips+=(${dest})
 	elif [[ ${dest} =~ ^(([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9\-]*[a-zA-Z0-9])\.)*([A-Za-z0-9]|[A-Za-z0-9][A-Za-z0-9\-]*[A-Za-z0-9])$ ]]; then
+		debug 'Dectect a hostname'
 		local dns=$(dig +short "${dest}" | grep -v '\.$' | xargs)
-		ips=($dns)
+		ips+=($dns)
 	else
 		error 'Destination argument is not a valide IP or Hostname'
 		cleanup 1
 	fi
-	declare -a ips
-	if ((${#ips[@]})); then
+	if ! ((${#ips[@]})); then
 		error 'No IP could be resolved for this hostname'
 		cleanup 1
 	fi
@@ -137,19 +139,17 @@ function getGwIp {
 function setRoute {
 	for ip in "${ips[@]}"; do
 		ip_route="${ip}/32"
+		debug 'Get sudo permission to set the IP route'
 		if command -v ip &> /dev/null; then
-			debug 'Get sudo permission to set the IP route'
 			sudo ip route add ${ip_route} dev ppp0
-			debug "Set ip route ${ip_route} through SSLVPN"
 		elif command -v netstat &> /dev/null; then
 			getGwIp
-			debug 'Get sudo permission to set the IP route'
 			sudo route add ${ip_route} ${gwip}
-			debug "Set ip route ${ip_route} through SSLVPN"
 		else
 			error 'Please install iproute2 or net-tools'
 			cleanup 1
 		fi
+		debug "Set ip route ${ip_route} through SSLVPN"
 	done
 }